Skip to content

new builtin parameter: fix test expectations#520

Merged
clalancette merged 1 commit intoros2:rollingfrom
emersonknapp:emersonknapp/new-parameter-test-fix
Jul 7, 2023
Merged

new builtin parameter: fix test expectations#520
clalancette merged 1 commit intoros2:rollingfrom
emersonknapp:emersonknapp/new-parameter-test-fix

Conversation

@emersonknapp
Copy link
Contributor

@emersonknapp emersonknapp commented Jul 4, 2023 •
edited
Loading

Part of ros2/ros2#1159

Linked with ros2/rclcpp#2224

Fixes expected parameters, now that start_type_description_service is added.

@emersonknapp
Add a fix for thetests given the new builtin parameter
41fbdfb 
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
This was referenced Jul 4, 2023
Merged
Merged
@emersonknapp emersonknapp changed the title Add a fix for thetests given the new builtin parameter new builtin parameter: fix test expectations Jul 4, 2023
@emersonknapp emersonknapp mentioned this pull request Jul 4, 2023
Closed
14 tasks
@emersonknapp
Copy link
Contributor Author

emersonknapp commented Jul 4, 2023 •
edited
Loading

Pulls: ros2/rcl#1052, ros2/rclcpp#2224, #520
Gist: https://gist.githubusercontent.com/emersonknapp/b250eee074072eeb11c1a6d544866179/raw/e787e5a7cbeadb0ba5865e439578867d581b682d/ros2.repos
BUILD args: --packages-above-and-dependencies rcl rcl_action rclcpp rclcpp_lifecycle test_rclcpp
TEST args: --packages-above rcl rcl_action rclcpp rclcpp_lifecycle test_rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/12318

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Build Status
  • Windows Build Status

@emersonknapp
Copy link
Contributor Author

emersonknapp commented Jul 5, 2023 •
edited
Loading

Pulls: ros2/rcl#1052, ros2/rclcpp#2224, #520
Gist: https://gist.githubusercontent.com/emersonknapp/61666ed4bfef7aa7b2f349cd87122a42/raw/e787e5a7cbeadb0ba5865e439578867d581b682d/ros2.repos
BUILD args: --packages-above-and-dependencies rcl rcl_action rclcpp rclcpp_lifecycle test_rclcpp
TEST args: --packages-above rcl rcl_action rclcpp rclcpp_lifecycle test_rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/12324

  • Linux Build Status
    • Build Status
    • Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette clalancette merged commit 6991036 into ros2:rolling Jul 7, 2023
@emersonknapp
Copy link
Contributor Author

emersonknapp commented Jul 7, 2023

@Mergifyio backport iron

@mergify
Copy link

mergify bot commented Jul 7, 2023

backport iron

❌ Command disallowed due to command restrictions in the Mergify configuration.

Details
  • sender-permission>=write

emersonknapp added a commit to emersonknapp/system_tests that referenced this pull request Jul 7, 2023
@emersonknapp
Add a fix for the tests given the new type description parameter (ros…
47cb747 
…2#520)

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@emersonknapp emersonknapp mentioned this pull request Jul 7, 2023
Merged
@emersonknapp
Copy link
Contributor Author

emersonknapp commented Jul 7, 2023

^^ I'm going to manually create backports from my forks since I will likely need to make edits and don't have write permissions on these repos

clalancette pushed a commit that referenced this pull request Jul 18, 2023
@emersonknapp
Add a fix for the tests given the new type description parameter (#520)…
10cf1e6 
… (#521)

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clalancette clalancette clalancette approved these changes

@methylDragon methylDragon Awaiting requested review from methylDragon

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@emersonknapp @clalancette